refactor: Align IVF and AMVF in examples #2144
Conversation
andiwand
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
+ Coverage 49.46% 49.50% +0.03%
==========================================
Files 436 436
Lines 25129 25128 -1
Branches 11606 11605 -1
==========================================
+ Hits 12431 12440 +9
+ Misses 4464 4431 -33
- Partials 8234 8257 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 0bbaa78Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
There was a problem hiding this comment.
As discussed on mattermost seems like the whole performance improve comes from a different seeder. The IVF algorithm with the track weights hardcoded at 1 seems like it's still not complete. But I think that could be addressed in a different PR. I would discourage to actually use the the cutOffTrackWeightReassign parameter if the trackWeights are not properly set. (probably disable it until then?)
| VertexSeeder seeder(seederCfg); | ||
| IPEstimator::Config ipEstCfg(m_cfg.bField, propagator); | ||
| IPEstimator ipEst(ipEstCfg); | ||
| Seeder seeder; |
There was a problem hiding this comment.
I aligned this with the AMVF. Now we use the TrackDensityVertexFinder which seems to go fine with the default constructed GaussianTrackDensity
IVF and AMVF use different seeders and the code diverged quite a bit in the examples. In this PR I try to realign them