chore: Wire loggers in CKF correctly

[andiwand]

That way updater and smoother logs will not be automatically silenced

[paulgessinger]

How about using suffixes?

Also, the logger should be created ahead of time, otherwise we do a lot of unnecessary heap allocations. Also consider that this is only not dangling because of lifetime extension (clone() returns a unique_ptr, which you dereference), which I'd prefer to avoid.

[andiwand]

good point - I adopted this now

[paulgessinger]

Thank! LGTM

[codecov]

Codecov Report

Merging #2146 (20184c0) into main (aff0c55) will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##             main    #2146   +/-   ##
=======================================
  Coverage   49.46%   49.46%           
=======================================
  Files         434      434           
  Lines       25009    25015    +6     
  Branches    11523    11525    +2     
=======================================
+ Hits        12370    12374    +4     
  Misses       4489     4489           
- Partials     8150     8152    +2     

Impacted Files	Coverage Δ
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp	31.83% <57.14%> (+0.49%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for 20184c0

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[paulgessinger]

The job queue overflow fails sentinel, I'm merging manually.