-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: python binding for Detector #2198
feat: python binding for Detector #2198
Conversation
📊 Physics performance monitoring for cbf868cSummary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #2198 +/- ##
==========================================
+ Coverage 49.32% 49.37% +0.05%
==========================================
Files 441 446 +5
Lines 25247 25290 +43
Branches 11643 11657 +14
==========================================
+ Hits 12452 12488 +36
+ Misses 4520 4515 -5
- Partials 8275 8287 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
747180e
to
79bd634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! left a few formatting comments and questions. happy to re-review/approve
Hey @andiwand - I think I addressed all comments now. |
there are a bunch on conflicts after IWYU fixes went in - I can approve when this is fixed |
Generally I would caution against exposing types with different names and outside of their C++ scope, i.e. a nested enum/struct whatever should be exposed as a nested type in python. Otherwise I'm a bit worried this might cause confusion. |
This PR introduces python bindings for the new Experimental detectors:
DetectorBuilder
, its interface and appropriatepython
bindings.RootDetectorVolumes
are now pushed into theDetectorComponents
.DetectorInspectors
redundant, as this can now be done purely in pythonAs an example, one can now build a detector with one volume simply as: