Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Allow TrackState copyFrom for different MTJs #2204

Merged
merged 2 commits into from
Jun 14, 2023
Merged

refactor: Allow TrackState copyFrom for different MTJs #2204

merged 2 commits into from
Jun 14, 2023

Conversation

paulgessinger
Copy link
Member

This allows copying between MTJ backends by relaxing the template arguments.

@paulgessinger paulgessinger added this to the next milestone Jun 13, 2023
@paulgessinger
Copy link
Member Author

@goetzgaycken

@paulgessinger paulgessinger mentioned this pull request Jun 13, 2023
Merged
@goetzgaycken
Copy link
Contributor

I also had to give the TrackStateProxy access to calll referenceSurfacePointer of the ConstTrackStateProxy in v25.0.1

@paulgessinger
Copy link
Member Author

I think that should not be needed anymore in 26+ anyway

@github-actions github-actions bot added the Component - Core Affects the Core module label Jun 13, 2023
@noemina noemina self-requested a review June 13, 2023 15:22
noemina
noemina approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@noemina noemina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. Approved.

@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #2204 (53e02b1) into main (80cc195) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 53e02b1 differs from pull request most recent head 4d2ab04. Consider uploading reports for the commit 4d2ab04 to get more accurate results

@@            Coverage Diff             @@
##             main    #2204      +/-   ##
==========================================
+ Coverage   49.33%   49.38%   +0.04%     
==========================================
  Files         441      441              
  Lines       25207    25172      -35     
  Branches    11622    11616       -6     
==========================================
- Hits        12436    12431       -5     
+ Misses       4513     4485      -28     
+ Partials     8258     8256       -2
Impacted Files Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp 71.03% <100.00%> (-0.22%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 13, 2023 •
edited
Loading

📊 Physics performance monitoring for 4d2ab04

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger paulgessinger mentioned this pull request Jun 14, 2023
Merged
@kodiakhq kodiakhq bot merged commit d7f13e5 into acts-project:main Jun 14, 2023
kodiakhq bot pushed a commit that referenced this pull request Jun 15, 2023
@paulgessinger
refactor: TrackProxy::copyFrom copies track states (#2205)
fc0e58c 
This uses a newly added function to reverse track states to create the track states with reverted order and then flip the order around to produce a good copy.

Blocked by:
- #2204
@paulgessinger paulgessinger modified the milestones: next, v27.0.0 Jun 20, 2023
kodiakhq bot pushed a commit that referenced this pull request Jul 6, 2023
@paulgessinger
perf: Reduce memory consumption of track finding (#2206)
5bd016c 
We use a lot of memory in busy events, e.g. for ttbar pu200 we use multiple gigabytes of track state storage.
This PR reduces this by rolling a track selection into the track finding algorithm. The CKF now operates on a temporary track container that is cleared between seeds and reused. Only tracks that pass the selection are copied into the output collection. 

In my testing this reduces the memory consumption by about 2x.

Before:
![main_PrMon_wtime_vs_vmem_pss_rss_swap](https://github.com/acts-project/acts/assets/1058585/38d424fc-6a36-4f01-a522-5bb89e756409)
After:
![feat_v3_PrMon_wtime_vs_vmem_pss_rss_swap](https://github.com/acts-project/acts/assets/1058585/36df26c7-701e-478c-b972-c1bd6ab2027c)


Blocked by:
- #2202
- #2201
- #2203
- #2204
- #2205
- #2267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noemina noemina noemina approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module
Projects
None yet
Milestone
v27.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @goetzgaycken @noemina