-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add codespell to CI #2218
ci: Add codespell to CI #2218
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2218 +/- ##
=======================================
Coverage 49.36% 49.36%
=======================================
Files 445 445
Lines 25259 25259
Branches 11646 11646
=======================================
Hits 12468 12468
Misses 4511 4511
Partials 8280 8280
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 3f72618Summary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. maybe @paulgessinger wants to take a look before we merge
Could be a good idea. Did you check this for false hits? |
Also: could we get the FPE PR in before this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added dThe
to the ignore list.
Do we need to mark this PR as breaking since auxiliary
may be part of the python API?
Examples/Detectors/GenericDetector/include/ActsExamples/GenericDetector/ProtoLayerCreatorT.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
The python API is not subject of our versioning I think. |
This adds a spell checking tool to the CI along with a lot of fixes.