Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: draw measurements in e.g. .obj, refactor and update unittests #2229

Merged
merged 12 commits into from
Jun 28, 2023
Merged

feat: draw measurements in e.g. .obj, refactor and update unittests #2229

merged 12 commits into from
Jun 28, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Jun 21, 2023 •
edited
Loading

A new function+unittest for visualising measurements as ellipses.

In the future, we maybe also want to add the possibility to display 1D measurements.

Refined all EventDataView3D-Unittests.

Fixed also some typos missed by the spellcheck.

@github-actions github-actions bot added the Component - Core Affects the Core module label Jun 21, 2023
@AJPfleger AJPfleger requested a review from asalzburger June 21, 2023 12:19
@AJPfleger AJPfleger added this to the next milestone Jun 21, 2023
@AJPfleger AJPfleger added the Feature Development to integrate a new feature label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #2229 (b995fd7) into main (1256675) will increase coverage by 0.00%.
The diff coverage is 37.50%.

@@           Coverage Diff           @@
##             main    #2229   +/-   ##
=======================================
  Coverage   49.26%   49.26%           
=======================================
  Files         449      449           
  Lines       25398    25403    +5     
  Branches    11721    11723    +2     
=======================================
+ Hits        12513    12516    +3     
- Misses       4553     4554    +1     
- Partials     8332     8333    +1
Impacted Files Coverage Δ
...ore/include/Acts/Visualization/EventDataView3D.hpp 47.56% <37.50%> (+0.80%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

asalzburger
asalzburger requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for a first implementation, the 1D case would also be great - but more importantly, can you add a UnitTest in Tests/Visualization ?

@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

📊 Physics performance monitoring for b995fd7

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@AJPfleger AJPfleger added the 🚧 WIP Work-in-progress label Jun 21, 2023
@AJPfleger AJPfleger changed the title feat: draw measurements in e.g. .obj feat: draw measurements in e.g. .obj, refactor and update unittests Jun 22, 2023
@AJPfleger AJPfleger removed the 🚧 WIP Work-in-progress label Jun 22, 2023
@AJPfleger
Copy link
Contributor Author

Good for a first implementation, the 1D case would also be great - but more importantly, can you add a UnitTest in Tests/Visualization ?

I added 2 unit tests checking for errors in the output and also comparing the length (lines) of the output to a reference value. I also added the length-check to the 4 other tests of the same kind.

@AJPfleger AJPfleger requested a review from asalzburger June 22, 2023 18:18
asalzburger
asalzburger approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And off we go.

@kodiakhq kodiakhq bot merged commit 60bb598 into acts-project:main Jun 28, 2023
@paulgessinger paulgessinger removed this from the next milestone Jul 4, 2023
@paulgessinger paulgessinger added this to the v27.1.0 milestone Jul 4, 2023
noemina pushed a commit to noemina/acts that referenced this pull request Jul 5, 2023
@AJPfleger @noemina
feat: draw measurements in e.g. .obj, refactor and update unittests (…
b23b564 
…acts-project#2229)

A new function+unittest for visualising measurements as ellipses.

In the future, we maybe also want to add the possibility to display 1D measurements.

Refined all `EventDataView3D`-Unittests.

Fixed also some typos missed by the spellcheck.
@AJPfleger AJPfleger deleted the draw-measurement branch December 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Feature Development to integrate a new feature
Projects
None yet
Milestone
v27.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AJPfleger @asalzburger @paulgessinger