Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move ParticleData from Fatras to Core #2233

Merged
merged 11 commits into from
Jun 28, 2023

Conversation

andiwand
Copy link
Contributor

I would like to move ParticleData to Core so we have one central spot to get mass and charge for a PDG particle identifier.

This can the be utilized in #2181

@andiwand andiwand added Component - Core Affects the Core module Component - Fatras Affects the Fatras module labels Jun 22, 2023
@andiwand andiwand added this to the next milestone Jun 22, 2023
@github-actions github-actions bot added Component - Examples Affects the Examples module Event Data Model labels Jun 22, 2023
@paulgessinger
Copy link
Member

Should we discuss this interactively in the meeting?

@benjaminhuth
Copy link
Member

benjaminhuth commented Jun 22, 2023

Should we discuss this interactively in the meeting?

This is maybe somehow related to #2230, so we could discuss this together

@andiwand
Copy link
Contributor Author

try make everything constexpr

@andiwand
Copy link
Contributor Author

constexpr did not work all the way because std::find only has it from C++20 onwards

@benjaminhuth
Copy link
Member

Ah thats sad... Hmm so one possibility would be to provide a find implementation pre C++20 (see e.g. here: https://en.cppreference.com/w/cpp/algorithm/find#Possible_implementation) and switch std::find only in C++20 and above...

@andiwand
Copy link
Contributor Author

right that would be an option. I think that could be a separate effort to poly fill a few common functions which limit us in our constexpr abilities. for this PR I would like to keep it out to simplify things and get moving

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@bd785d9). Click here to learn what that means.
The diff coverage is 37.87%.

@@           Coverage Diff           @@
##             main    #2233   +/-   ##
=======================================
  Coverage        ?   49.26%           
=======================================
  Files           ?      449           
  Lines           ?    25398           
  Branches        ?    11721           
=======================================
  Hits            ?    12513           
  Misses          ?     4553           
  Partials        ?     8332           
Impacted Files Coverage Δ
Core/include/Acts/Definitions/PdgParticle.hpp 0.00% <0.00%> (ø)
Core/include/Acts/Propagator/Propagator.hpp 93.33% <ø> (ø)
Core/src/Material/Interactions.cpp 74.19% <ø> (ø)
Core/src/Definitions/ParticleData.cpp 38.46% <38.46%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 28, 2023

📊 Physics performance monitoring for 3bde52b

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand
Copy link
Contributor Author

hmmm physmon crashed but I don't see how this can be. rerunning.

@kodiakhq kodiakhq bot merged commit 1256675 into acts-project:main Jun 28, 2023
@andiwand andiwand deleted the move-particle-data-to-core branch June 29, 2023 07:08
@paulgessinger paulgessinger modified the milestones: next, v27.1.0 Jul 4, 2023
noemina pushed a commit to noemina/acts that referenced this pull request Jul 5, 2023
I would like to move `ParticleData` to `Core` so we have one central spot to get mass and charge for a PDG particle identifier.

This can the be utilized in acts-project#2181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants