Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clear method for Track Container #2290

Merged
merged 6 commits into from
Jul 11, 2023
Merged

feat: clear method for Track Container #2290

merged 6 commits into from
Jul 11, 2023

Conversation

CarloVarni
Copy link
Collaborator

I figured this may come in handy

@CarloVarni CarloVarni added this to the next milestone Jul 10, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Track Finding labels Jul 10, 2023
@CarloVarni CarloVarni marked this pull request as draft July 10, 2023 11:05
@CarloVarni CarloVarni marked this pull request as ready for review July 10, 2023 11:16
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #2290 (3a7cee8) into main (679e7a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2290   +/-   ##
=======================================
  Coverage   49.27%   49.27%           
=======================================
  Files         450      450           
  Lines       25408    25408           
  Branches    11727    11727           
=======================================
  Hits        12521    12521           
  Misses       4549     4549           
  Partials     8338     8338
Impacted Files Coverage Δ
Core/include/Acts/EventData/TrackContainer.hpp 89.04% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

📊 Physics performance monitoring for 3a7cee8

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@CarloVarni CarloVarni requested a review from andiwand July 11, 2023 13:34
andiwand
andiwand approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit c4ba836 into acts-project:main Jul 11, 2023
@CarloVarni CarloVarni deleted the TrackContainerClearOption branch July 11, 2023 14:10
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 11, 2023 •
edited
Loading

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status job
🔴 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsTrkSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 11, 2023
@CarloVarni CarloVarni removed the Fails Athena tests This PR causes a failure in the Athena tests label Jul 11, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 11, 2023
@CarloVarni CarloVarni removed the Fails Athena tests This PR causes a failure in the Athena tests label Jul 11, 2023
@paulgessinger paulgessinger modified the milestones: next, v27.2.0 Jul 24, 2023
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Jul 24, 2023
@CarloVarni @paulgessinger
feat: clear method for Track Container (acts-project#2290)
882d6ba 
I figured this may come in handy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Track Finding
Projects
None yet
Milestone
v27.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CarloVarni @acts-project-service @andiwand @paulgessinger