chore: Adopt physmon plotting ranges #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
📊 Physics performance monitoring for e5857a5Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #2294 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 450 450
Lines 25408 25408
Branches 11727 11727
=======================================
Hits 12521 12521
Misses 4549 4549
Partials 8338 8338 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CarloVarni
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Hi @andiwand lgtm.
The changes performance label is just caused by the change of the ranges, and not a "real physiscs" change. So I'd say we are good with this
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
Physmon plotting ranges are not optimal right now. Here I am trying to improve things by properly scaling the axes to what is needed
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
…roject#2086) Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution. Fixes - acts-project#1643 Blocked by - acts-project#2157 - acts-project#2239 - acts-project#2295 - acts-project#2293 - acts-project#2294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Physmon plotting ranges are not optimal right now. Here I am trying to improve things by properly scaling the axes to what is needed