-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: minimum number of top SPs in orthogonal seeding confirmation #2298
feat: minimum number of top SPs in orthogonal seeding confirmation #2298
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 49.65% 49.47% -0.18%
==========================================
Files 453 451 -2
Lines 25534 25484 -50
Branches 11708 11720 +12
==========================================
- Hits 12679 12609 -70
- Misses 4574 4582 +8
- Partials 8281 8293 +12 see 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 91c7d32physmon summary
|
This one is ready for review (not WIP) |
@stephenswat could you give this a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Looks good to me.
System failure unrelated to PR content. |
I realised there was a step in seeding confirmation missing in the orthogonal seeding.
This avoids searching for top SPs if we set a minimum number of top SPs required for a specific region of the detector based on the seeding confirmation configuration. Probably improves slightly the time performance.