Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimum number of top SPs in orthogonal seeding confirmation #2298

Merged
merged 11 commits into from
Aug 7, 2023

Conversation

LuisFelipeCoelho
Copy link
Member

I realised there was a step in seeding confirmation missing in the orthogonal seeding.
This avoids searching for top SPs if we set a minimum number of top SPs required for a specific region of the detector based on the seeding confirmation configuration. Probably improves slightly the time performance.

@github-actions github-actions bot added Component - Core Affects the Core module Seeding labels Jul 12, 2023
@andiwand andiwand added the 🚧 WIP Work-in-progress label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2298 (9b004c2) into main (3f4cbab) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 9b004c2 differs from pull request most recent head ad69cd5. Consider uploading reports for the commit ad69cd5 to get more accurate results

@@            Coverage Diff             @@
##             main    #2298      +/-   ##
==========================================
- Coverage   49.65%   49.47%   -0.18%     
==========================================
  Files         453      451       -2     
  Lines       25534    25484      -50     
  Branches    11708    11720      +12     
==========================================
- Hits        12679    12609      -70     
- Misses       4574     4582       +8     
- Partials     8281     8293      +12     

see 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review July 14, 2023 12:01
@LuisFelipeCoelho
Copy link
Member Author

LuisFelipeCoelho commented Jul 14, 2023

This one is ready for review (not WIP)
FYI: @CarloVarni @stephenswat @andiwand

@CarloVarni CarloVarni requested a review from stephenswat July 14, 2023 12:10
@CarloVarni CarloVarni added this to the next milestone Jul 14, 2023
@CarloVarni CarloVarni removed the 🚧 WIP Work-in-progress label Jul 14, 2023
@paulgessinger
Copy link
Member

@stephenswat could you give this a quick look?

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks good to me.

@paulgessinger paulgessinger modified the milestones: next, v28.1.0 Aug 7, 2023
@kodiakhq kodiakhq bot merged commit f651d07 into acts-project:main Aug 7, 2023
@github-actions github-actions bot removed the automerge label Aug 7, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 7, 2023
@paulgessinger
Copy link
Member

System failure unrelated to PR content.

@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 8, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 8, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants