refactor!: Consistent naming for direction

[andiwand]

The last PR in the series of having consistent naming for direction

After

• refactor: direction and qOverP for Fatras particle interface #2251
• refactor: Explicit direction parameter instead of momentum for Surface interface #2250

[codecov]

Codecov Report

Merging #2343 (a4c90ff) into main (49de0d3) will not change coverage.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##             main    #2343   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25512    25512           
  Branches    11706    11706           
=======================================
  Hits        12648    12648           
  Misses       4580     4580           
  Partials     8284     8284           

Files Changed	Coverage Δ
...ts/EventData/GenericCurvilinearTrackParameters.hpp	44.00% <0.00%> (ø)
Core/include/Acts/EventData/TrackProxy.hpp	78.70% <ø> (ø)
Core/include/Acts/Propagator/AtlasStepper.hpp	72.19% <ø> (ø)
Core/include/Acts/Propagator/EigenStepper.hpp	77.55% <0.00%> (ø)
.../include/Acts/Propagator/MultiEigenStepperLoop.ipp	40.62% <0.00%> (ø)
...re/include/Acts/Propagator/StraightLineStepper.hpp	73.52% <0.00%> (ø)
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp	44.59% <ø> (ø)
.../include/Acts/Vertexing/HelicalTrackLinearizer.ipp	19.23% <ø> (ø)
...nclude/Acts/Vertexing/NumericalTrackLinearizer.ipp	16.36% <0.00%> (ø)
...ore/include/Acts/Visualization/EventDataView3D.hpp	48.78% <0.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for a4c90ff

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

We can do this if you want, but naively I don't think it's necessarily bad to communicate that these vectors are normalized.

[andiwand]

I don't have a strong opinion on direction vs unitDirection but I think it should be consistent for track params, stepper and intersections. Happy to do it the other way by calling everything unitDirection

I guess if we opt for direction we could state somewhere that this always means unit direction across the codebase

[felix-russo]

I think the renaming is a good idea, since a direction is per definition a unit vector.
From Wikipedia:

[felix-russo]

If this change alright for @paulgessinger we can merge

[paulgessinger]

I restarted the CI.

[andiwand]

I would have kept this back for v29 because it might break Athena. what do you think @paulgessinger ?

[paulgessinger]

You're right, I missed that. Let's hold it.

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data