refactor: Remove direction from NavigationOptions and drop constructor

[andiwand]

I propose to drop the navigation direction from NavigationOptions as the direction vector parameter in the lookup functions is sufficient to provide the same functionality.

Additionally I removed the constructor of NavigationOptions which duplicated default values and was less explicit. I also removed the magic overstepping limit which will be overwritten by the one from the stepper anyways.

[codecov]

Codecov Report

Merging #2345 (08a3db7) into main (e9977db) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 46.51%.

@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
- Coverage   49.63%   49.63%   -0.01%     
==========================================
  Files         453      453              
  Lines       25540    25530      -10     
  Branches    11709    11705       -4     
==========================================
- Hits        12678    12672       -6     
+ Misses       4580     4579       -1     
+ Partials     8282     8279       -3     

Files Changed	Coverage Δ
Core/include/Acts/Navigation/DetectorNavigator.hpp	48.06% <ø> (ø)
Core/include/Acts/Propagator/DirectNavigator.hpp	75.71% <ø> (ø)
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp	31.78% <0.00%> (ø)
Core/include/Acts/Utilities/UnitVectors.hpp	60.71% <ø> (ø)
Core/src/Geometry/Layer.cpp	57.46% <0.00%> (+0.21%)	⬆️
Core/src/Geometry/TrackingVolume.cpp	48.84% <25.00%> (+0.41%)	⬆️
Core/include/Acts/Propagator/Navigator.hpp	57.11% <62.96%> (-0.12%)	⬇️
Core/include/Acts/TrackFitting/KalmanFitter.hpp	42.89% <100.00%> (-0.29%)	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 08a3db7

Full contents

physmon summary

• ✅ Ambisolver orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver
• ✅ AMVF orthogonal
• ✅ AMVF seeded
• ✅ AMVF truth_estimated
• ✅ AMVF truth_smeared
• ✅ AMVF ttbar
• ✅ CKF orthogonal
• ✅ CKF seeded
• ✅ CKF truth_estimated
• ✅ CKF truth_smeared
• ✅ CKF ttbar
• ✅ Truth tracking (GSF)
• ✅ IVF orthogonal
• ✅ IVF seeded
• ✅ IVF truth_estimated
• ✅ IVF truth_smeared
• ✅ Particles final fatras
• ✅ Particles final geant4
• ✅ Particles inital fatras
• ✅ Particles inital geant4
• ✅ Seeding orthogonal
• ✅ Seeding seeded
• ✅ Seeding truth_estimated
• ✅ Seeding ttbar
• ✅ Track Summary CKF orthogonal
• ✅ Track Summary CKF seeded
• ✅ Track Summary CKF truth_estimated
• ✅ Track Summary CKF truth_smeared
• ✅ Truth tracking

[andiwand]

apparently this is fixing a small navigation issue. when we target a layer in backward navigation we used to propagate one step in the wrong direction and proceed to the target. this is not the case anymore and therefore results are slightly changing

[benjaminhuth]

Let's get it in!

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data