Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: LineSurface back to col(2) for local z axis #2369

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

andiwand
Copy link
Contributor

Back to col(2) as it seems more optimal in terms of resources

@andiwand andiwand added this to the next milestone Aug 15, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2369 (1f537d2) into main (430eb1e) will increase coverage by 0.00%.
The diff coverage is 12.50%.

@@           Coverage Diff           @@
##             main    #2369   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25511    25513    +2     
  Branches    11706    11707    +1     
=======================================
+ Hits        12648    12649    +1     
  Misses       4579     4579           
- Partials     8284     8285    +1     
Files Changed Coverage Δ
Core/include/Acts/Surfaces/LineSurface.hpp 100.00% <ø> (ø)
Core/src/Surfaces/LineSurface.cpp 35.57% <12.50%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 951edca into acts-project:main Aug 15, 2023
@andiwand andiwand deleted the opt-line-surface-z-axis branch August 15, 2023 19:43
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 15, 2023
andiwand added a commit to andiwand/acts that referenced this pull request Aug 17, 2023
kodiakhq bot pushed a commit that referenced this pull request Aug 17, 2023
…" (#2377)

Unexpectedly #2369 seems to change the Athena output which should only happen in major versions of Acts.
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
andiwand added a commit to andiwand/acts that referenced this pull request Aug 18, 2023
kodiakhq bot pushed a commit that referenced this pull request Aug 18, 2023
second try after #2369

Back to `col(2)` as it seems more optimal in terms of resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants