fix: FPE in AnnealingUtility by using safeExp

[paulgessinger]

No description provided.

[codecov]

Codecov Report

Merging #2406 (b9725f9) into main (928ceef) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main    #2406   +/-   ##
=======================================
  Coverage   49.68%   49.69%           
=======================================
  Files         454      454           
  Lines       25807    25809    +2     
  Branches    11852    11852           
=======================================
+ Hits        12823    12825    +2     
  Misses       4581     4581           
  Partials     8403     8403           

Files Changed	Coverage Δ
Core/include/Acts/Utilities/AlgebraHelpers.hpp	60.93% <80.00%> (+1.26%)	⬆️
Core/src/Utilities/AnnealingUtility.cpp	94.73% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for b9725f9

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[felix-russo]

Nice!

[benjaminhuth]

still a merge conflict @paulgessinger

[benjaminhuth]

@paulgessinger something is going wrong in physmon...

[paulgessinger]

@benjaminhuth the gaussian mixture mask did not apply correctly.

[paulgessinger]

Seems to me like the change to the safeExp functions brings (back?) an FPD in the gaussian density vertex finder:

acts/Core/include/Acts/Vertexing/AdaptiveGridDensityVertexFinder.ipp

Line 26 in 928ceef

m_cfg.gridDensity.subtractTrack(trackDensityMap, state.mainDensityMap);

Did you see something in that area before @felix-russo ?

[felix-russo]

Seems to me like the change to the safeExp functions brings (back?) an FPD in the gaussian density vertex finder:

acts/Core/include/Acts/Vertexing/AdaptiveGridDensityVertexFinder.ipp

Line 26 in 928ceef

m_cfg.gridDensity.subtractTrack(trackDensityMap, state.mainDensityMap);

Did you see something in that area before @felix-russo ?

Yes - that was the reason for introducing safeExp originally:

acts/Core/include/Acts/Vertexing/AdaptiveGridTrackDensity.ipp

Line 211 in 928ceef

return coef * safeExp(expo);

)

My guess is that, for whatever reason, godbolt manages to calculate std::exp for smaller values than our machine. So before, when we used the cut-off value 50 for float everything worked, but now, when using 85, we run into the same FPE as before...

[benjaminhuth]

Hmm maybe we go back to more conservative values like 50 for float and 500 for double?

[paulgessinger]

Done now. Let's see how it goes.

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data