Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add GeoId constructor from value to bindings & restructure #2431

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Sep 7, 2023

  • Introduces new Framework.cpp to improve structure.
  • Move GeometryIdentifer-binding to Geometry.cpp
  • Add binding for GeometryIdentifier constructor from value

@benjaminhuth benjaminhuth added this to the next milestone Sep 7, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2431 (dc39ff1) into main (eee7051) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2431   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         455      455           
  Lines       25840    25840           
  Branches    11861    11861           
=======================================
  Hits        12843    12843           
  Misses       4592     4592           
  Partials     8405     8405           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@benjaminhuth benjaminhuth changed the title refactor: Add GeometryId constructor from value & restructure refactor: Add GeoId constructor from value to bindings & restructure Sep 7, 2023
andiwand
andiwand previously approved these changes Sep 7, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kodiakhq kodiakhq bot merged commit 03d2e5f into acts-project:main Sep 8, 2023
@github-actions github-actions bot removed the automerge label Sep 8, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.2.0 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants