Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propagation end of world #2452

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

asalzburger
Copy link
Contributor

Change the standard EndOfWorldApproached aborter to ask the Navigator and do not access directly the currentVolume.

@asalzburger asalzburger added this to the next milestone Sep 15, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module labels Sep 15, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! lets see what physmon says

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2452 (c666435) into main (f581704) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2452   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         461      461           
  Lines       25988    25989    +1     
  Branches    11935    11934    -1     
=======================================
+ Hits        12920    12921    +1     
  Misses       4600     4600           
  Partials     8468     8468           
Files Changed Coverage Δ
Core/include/Acts/Navigation/DetectorNavigator.hpp 48.06% <ø> (ø)
Core/include/Acts/Propagator/DirectNavigator.hpp 75.71% <ø> (ø)
Core/include/Acts/Propagator/Navigator.hpp 57.28% <100.00%> (+0.17%) ⬆️
Core/include/Acts/Propagator/StandardAborters.hpp 71.11% <100.00%> (-0.63%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asalzburger
Copy link
Contributor Author

cool! lets see what physmon says

It says: all good.

@kodiakhq kodiakhq bot merged commit 9e20cea into acts-project:main Sep 15, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.2.0 Sep 15, 2023
@asalzburger asalzburger deleted the feat-propagation-end-of-world branch September 19, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Fatras Affects the Fatras module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants