refactor: make usage of vertex constraint more evident

[felix-russo]

Removes intricate use of constraint in AMVFinder

[codecov]

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (a8a0576) 48.68% compared to head (ae9dc2f) 49.53%.
Report is 43 commits behind head on main.

❗ Current head ae9dc2f differs from pull request most recent head e8f9d9c. Consider uploading reports for the commit e8f9d9c to get more accurate results

Files	Patch %	Lines
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp	9.09%	5 Missing and 5 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp	16.66%	0 Missing and 5 partials ⚠️
Core/include/Acts/Vertexing/AMVFInfo.hpp	50.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2529      +/-   ##
==========================================
+ Coverage   48.68%   49.53%   +0.85%     
==========================================
  Files         478      474       -4     
  Lines       27888    27013     -875     
  Branches    13172    12474     -698     
==========================================
- Hits        13578    13382     -196     
+ Misses       4765     4762       -3     
+ Partials     9545     8869     -676     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for ae9dc2f

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[andiwand]

code looks fine but physmon seems to be degraded

[felix-russo]

code looks fine but physmon seems to be degraded

Yes, I didn't find the time to investigate yet, will do so shortly!

[acts-project-service]

🔴 Athena integration test results [e8f9d9c]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🔴	run_workflow_tests_run2_data
🔴	run_workflow_tests_run3_mc
🔴	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco

[felix-russo]

This should not break athena, I will investigate

[paulgessinger]

There also seems to be a unit test failure in AdaptiveMultiVertexFitter .

[paulgessinger]

The changes seen in Athena seem pretty wide, I see taus, jets and muons being widely affected. Not sure about the scale yet.

[felix-russo]

Yeah this should not affect athena! I will hopefully find the time to investigate soon, but this is not at all ready

[paulgessinger]

This seems to change the chi2/ndf quite visibly:

https://acts-athena-outputs.web.cern.ch/test_data18_13TeV_1000evt/pulls/2529/dcube_expert_last/