feat: middle SP z selection as result of grid binning #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for e403cd1physmon summary
|
andiwand
reviewed
Jun 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3286 +/- ##
=======================================
Coverage 47.34% 47.35%
=======================================
Files 511 511
Lines 30273 30270 -3
Branches 14686 14684 -2
=======================================
Hits 14333 14333
+ Misses 5400 5397 -3
Partials 10540 10540 ☔ View full report in Codecov by Sentry. |
|
I only added two questions, but besides that it looks good to me |
LuisFelipeCoelho
approved these changes
Jun 14, 2024
acts-project-service
added
the
Fails Athena tests
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
) This is trying to simplify the middle space point selection process during seeding. As of now we define a z-range validity for the middle space point candidate and when we loop on all the middle candidates we check the value of the z coordinate. This will do the same, but the selection on the z coordinate would be a consequence of the grid binning. In other words, this adds two new grid bins in the z dimension (covering the range `2700 < |z| < 3000 mm`). These bins will be skipped during grid iteration as middle candidates. Other parameters are adapted accordingly in order to return the same seeds as before. Tagging @noemina @LuisFelipeCoelho @paulgessinger and @andiwand Eventually, we may want to do the same for the r-coordinate and completely remove the checks for the middles space point validity
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
) This is trying to simplify the middle space point selection process during seeding. As of now we define a z-range validity for the middle space point candidate and when we loop on all the middle candidates we check the value of the z coordinate. This will do the same, but the selection on the z coordinate would be a consequence of the grid binning. In other words, this adds two new grid bins in the z dimension (covering the range `2700 < |z| < 3000 mm`). These bins will be skipped during grid iteration as middle candidates. Other parameters are adapted accordingly in order to return the same seeds as before. Tagging @noemina @LuisFelipeCoelho @paulgessinger and @andiwand Eventually, we may want to do the same for the r-coordinate and completely remove the checks for the middles space point validity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trying to simplify the middle space point selection process during seeding. As of now we define a z-range validity for the middle space point candidate and when we loop on all the middle candidates we check the value of the z coordinate.
This will do the same, but the selection on the z coordinate would be a consequence of the grid binning.
In other words, this adds two new grid bins in the z dimension (covering the range
2700 < |z| < 3000 mm). These bins will be skipped during grid iteration as middle candidates.Other parameters are adapted accordingly in order to return the same seeds as before.
Tagging @noemina @LuisFelipeCoelho @paulgessinger and @andiwand
Eventually, we may want to do the same for the r-coordinate and completely remove the checks for the middles space point validity