Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle if all branches are stopped after filtering in Core CKF #3555

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

andiwand
Copy link
Contributor

This bug was revealed and amplified after #3541. It is possible that all branches are stopped after the filtering step which should also trigger the CKF to stop.

@andiwand andiwand added this to the next milestone Aug 26, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

📊: Physics performance monitoring for 4609e8d

Full contents

physmon summary

@kodiakhq kodiakhq bot merged commit 666d7e4 into acts-project:main Aug 26, 2024
41 checks passed
Copy link

sonarcloud bot commented Aug 26, 2024

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 26, 2024
@andiwand andiwand deleted the fix-ckf-no-branches-after-filter branch August 27, 2024 05:17
andiwand added a commit that referenced this pull request Aug 28, 2024
…3555)

This bug was revealed and amplified after #3541. It is possible that all branches are stopped after the filtering step which should also trigger the CKF to stop.
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants