feat: Gen 3 portal shells #3564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
paulgessinger
force-pushed
the
feat/gen3-portal-shells
branch
2 times, most recently
from
fd8bf1f to
5ba9615
Compare
paulgessinger
force-pushed
the
feat/gen3-portal-shells
branch
4 times, most recently
from
5e90245 to
6bec609
Compare
paulgessinger
force-pushed
the
feat/gen3-portal-shells
branch
from
6bec609 to
96b1468
Compare
paulgessinger
force-pushed
the
feat/gen3-portal-shells
branch
from
96b1468 to
7f517d4
Compare
fixup: PortalShell.cpp in cmakelists
This works for single cylinders and for cylinder stacks
E.g. the cylinder stack shell will return nullptr on phi plane portal access, instead of throwing an exception.
paulgessinger
force-pushed
the
feat/gen3-portal-shells
branch
from
426b2ef to
7e079e5
Compare
andiwand
approved these changes
Oct 2, 2024
Open
Open
|
acts-project-service
added
the
Fails Athena tests
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
Part of acts-project#3502 Blocked by: - acts-project#3673 --- This pull request introduces the new `PortalShell` classes to the Acts geometry module, along with corresponding unit tests. The changes are primarily focused on adding new functionality for handling portal shells in tracking volumes. ### New Functionality: * [`Core/include/Acts/Geometry/PortalShell.hpp`](diffhunk://#diff-80595cf723b4c4b0a2cf3de28ac0da38793f2955a2e0ce1dc4fd87381fac79aeR1-R115): Introduced new `PortalShell` classes, including `PortalShellBase`, `CylinderPortalShell`, `SingleCylinderPortalShell`, and `CylinderStackPortalShell`. These classes provide interfaces and implementations for managing portals within cylindrical tracking volumes. * [`Core/src/Geometry/PortalShell.cpp`](diffhunk://#diff-4d9e1b25351b7d20e1dbdc440060aa02eaab832aabfde0b621c44bf8241ca7b8R1-R387): Implemented the methods for the new `PortalShell` classes, including portal management and validation logic. ### Build System Updates: * [`Core/src/Geometry/CMakeLists.txt`](diffhunk://#diff-5d46d063bba89d4f5042c2ba4cdfbdcb77335367cb0ce9800dd5d036011e2c56R45): Added the new `PortalShell.cpp` source file to the build system. * [`Tests/UnitTests/Core/Geometry/CMakeLists.txt`](diffhunk://#diff-569c5da4fca89fb082a2e207221e8d00cde5d6352c26878d8df0e11ef9f148eeR37): Added a new unit test for `PortalShell` to ensure the new functionality is properly tested.
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
Part of acts-project#3502 Blocked by: - acts-project#3673 --- This pull request introduces the new `PortalShell` classes to the Acts geometry module, along with corresponding unit tests. The changes are primarily focused on adding new functionality for handling portal shells in tracking volumes. ### New Functionality: * [`Core/include/Acts/Geometry/PortalShell.hpp`](diffhunk://#diff-80595cf723b4c4b0a2cf3de28ac0da38793f2955a2e0ce1dc4fd87381fac79aeR1-R115): Introduced new `PortalShell` classes, including `PortalShellBase`, `CylinderPortalShell`, `SingleCylinderPortalShell`, and `CylinderStackPortalShell`. These classes provide interfaces and implementations for managing portals within cylindrical tracking volumes. * [`Core/src/Geometry/PortalShell.cpp`](diffhunk://#diff-4d9e1b25351b7d20e1dbdc440060aa02eaab832aabfde0b621c44bf8241ca7b8R1-R387): Implemented the methods for the new `PortalShell` classes, including portal management and validation logic. ### Build System Updates: * [`Core/src/Geometry/CMakeLists.txt`](diffhunk://#diff-5d46d063bba89d4f5042c2ba4cdfbdcb77335367cb0ce9800dd5d036011e2c56R45): Added the new `PortalShell.cpp` source file to the build system. * [`Tests/UnitTests/Core/Geometry/CMakeLists.txt`](diffhunk://#diff-569c5da4fca89fb082a2e207221e8d00cde5d6352c26878d8df0e11ef9f148eeR37): Added a new unit test for `PortalShell` to ensure the new functionality is properly tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3502
Blocked by:
This pull request introduces the new
PortalShellclasses to the Acts geometry module, along with corresponding unit tests. The changes are primarily focused on adding new functionality for handling portal shells in tracking volumes.New Functionality:
Core/include/Acts/Geometry/PortalShell.hpp: Introduced newPortalShellclasses, includingPortalShellBase,CylinderPortalShell,SingleCylinderPortalShell, andCylinderStackPortalShell. These classes provide interfaces and implementations for managing portals within cylindrical tracking volumes.Core/src/Geometry/PortalShell.cpp: Implemented the methods for the newPortalShellclasses, including portal management and validation logic.Build System Updates:
Core/src/Geometry/CMakeLists.txt: Added the newPortalShell.cppsource file to the build system.Tests/UnitTests/Core/Geometry/CMakeLists.txt: Added a new unit test forPortalShellto ensure the new functionality is properly tested.