fix: added GeoShapeSubtraction converter for the failing conversion of RPCs to SensitiveSurface #3592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com>
Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com>
…ers.hpp Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
…rSurfaceFactory.hpp Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
dimitra97
previously approved these changes
Sep 20, 2024
acts-policybot
bot
dismissed
dimitra97’s stale review
Invalidated by push of 1ca0df3
dimitra97
approved these changes
Sep 20, 2024
dimitra97
approved these changes
Sep 26, 2024
|
acts-project-service
added
the
Fails Athena tests
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
…f RPCs to SensitiveSurface (acts-project#3592) Doing some tests I have realized that not all RPCs in the ATLAS database are described by `GeoBox`. Some are described by `GeoShapeSubtraction`, for which no converters existed. Therefor I added a `GeoSubtractionConverter` that recursively works through the subtractions until a shape is found for which a different converter exists. Now all RPCs can be converted by the `GeoModelDetectorObjectFactory` with the command `python3 geomodel_vol.py -i ~/ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -ml RPCgas -n RpcGasGap RPC` 
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
…f RPCs to SensitiveSurface (acts-project#3592) Doing some tests I have realized that not all RPCs in the ATLAS database are described by `GeoBox`. Some are described by `GeoShapeSubtraction`, for which no converters existed. Therefor I added a `GeoSubtractionConverter` that recursively works through the subtractions until a shape is found for which a different converter exists. Now all RPCs can be converted by the `GeoModelDetectorObjectFactory` with the command `python3 geomodel_vol.py -i ~/ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -ml RPCgas -n RpcGasGap RPC` 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some tests I have realized that not all RPCs in the ATLAS database are described by
GeoBox. Some are described byGeoShapeSubtraction, for which no converters existed. Therefor I added aGeoSubtractionConverterthat recursively works through the subtractions until a shape is found for which a different converter exists. Now all RPCs can be converted by theGeoModelDetectorObjectFactorywith the commandpython3 geomodel_vol.py -i ~/ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -ml RPCgas -n RpcGasGap RPC