Skip to content

refactor: add C++23 std::ranges::contains place holder #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 10, 2024

Conversation

AJPfleger
Copy link
Contributor

Search-based algorithm that checks whether or not a given range contains a value with iterator-sentinel pairs.

This utility simplifies range-based searches and will be replaceable with std::ranges::contains in C++23.

@AJPfleger AJPfleger added this to the next milestone Sep 6, 2024
@AJPfleger AJPfleger changed the title refactor: add rangeContainsValue as C++23 std::ranges::contains place holder refactor: add C++23 std::ranges::contains place holder Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

📊: Physics performance monitoring for 87a53ae

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review September 6, 2024 17:48
stephenswat
stephenswat previously approved these changes Sep 10, 2024
@acts-policybot acts-policybot bot dismissed stephenswat’s stale review September 10, 2024 18:46

Invalidated by push of ceb9746

Copy link

@kodiakhq kodiakhq bot merged commit ae0c21d into acts-project:main Sep 10, 2024
42 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 11, 2024
@AJPfleger AJPfleger deleted the contains branch September 11, 2024 05:23
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
njacazio pushed a commit to njacazio/acts that referenced this pull request Jun 13, 2025
…t#3598)

Search-based algorithm that checks whether or not a given range contains a value with iterator-sentinel pairs.

This utility simplifies range-based searches and will be replaceable with [`std::ranges::contains`](https://en.cppreference.com/w/cpp/algorithm/ranges/contains) in C++23.
njacazio pushed a commit to njacazio/acts that referenced this pull request Jun 13, 2025
…t#3598)

Search-based algorithm that checks whether or not a given range contains a value with iterator-sentinel pairs.

This utility simplifies range-based searches and will be replaceable with [`std::ranges::contains`](https://en.cppreference.com/w/cpp/algorithm/ranges/contains) in C++23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clustering Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model Fails Athena tests This PR causes a failure in the Athena tests Track Finding Track Fitting Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants