-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add measurement emplace functions #3627
feat: Add measurement emplace functions #3627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice 👍 Two more requests
- Could you add tests for this interface?
- Would you be up to change the existing measurements creation in the Examples to the new interface?
Examples/Framework/include/ActsExamples/EventData/Measurement.hpp
Outdated
Show resolved
Hide resolved
Examples/Framework/include/ActsExamples/EventData/Measurement.hpp
Outdated
Show resolved
Hide resolved
32b87da
to
20ef8ba
Compare
I went and:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Two small remarks but nothing crucial
Examples/Framework/include/ActsExamples/EventData/Measurement.hpp
Outdated
Show resolved
Hide resolved
Examples/Framework/include/ActsExamples/EventData/Measurement.hpp
Outdated
Show resolved
Hide resolved
20ef8ba
to
fcf6100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thank you!
fcf6100
to
0931134
Compare
Recently, the measurement EDM was replaced by a memory-optimal bulk storage, but this makes it a bit harder to add new measurements to a collection. This commit adds two new emplace functions which variadically allow users to add measurements, similar to how they might use `std::vector::emplace_back`.
Quality Gate passedIssues Measures |
Recently, the measurement EDM was replaced by a memory-optimal bulk storage, but this makes it a bit harder to add new measurements to a collection. This commit adds two new emplace functions which variadically allow users to add measurements, similar to how they might use
std::vector::emplace_back
.