Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add measurement emplace functions #3627

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

stephenswat
Copy link
Member

Recently, the measurement EDM was replaced by a memory-optimal bulk storage, but this makes it a bit harder to add new measurements to a collection. This commit adds two new emplace functions which variadically allow users to add measurements, similar to how they might use std::vector::emplace_back.

@github-actions github-actions bot added Component - Examples Affects the Examples module Event Data Model labels Sep 18, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👍 Two more requests

  1. Could you add tests for this interface?
  2. Would you be up to change the existing measurements creation in the Examples to the new interface?

Copy link

github-actions bot commented Sep 18, 2024

📊: Physics performance monitoring for 9ed4018

Full contents

physmon summary

@stephenswat
Copy link
Member Author

I went and:

  1. Added tests for these new methods;
  2. Converted all instances of makeMeasurement to these new methods;
  3. Added a named measurement concept.

andiwand
andiwand previously approved these changes Sep 19, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Two small remarks but nothing crucial

andiwand
andiwand previously approved these changes Sep 19, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you!

Recently, the measurement EDM was replaced by a memory-optimal bulk
storage, but this makes it a bit harder to add new measurements to a
collection. This commit adds two new emplace functions which
variadically allow users to add measurements, similar to how they might
use `std::vector::emplace_back`.
Copy link

sonarcloud bot commented Sep 25, 2024

@kodiakhq kodiakhq bot merged commit a129eeb into acts-project:main Sep 26, 2024
42 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [a129eeb]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 26, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants