fix: Reject material states when no measurements are found yet in Core CKF #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Infrastructure
|
|
@paulgessinger can we override sonarcloud here? |
paulgessinger
approved these changes
Sep 26, 2024
acts-project-service
added
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Since the Core CKF is growing into its own components which is then absorbed by a track finding algorithm it also allows us to extend tracks into different regions of the detector. While extending tracks we map want to keep eventual holes/material/outliers states at the end or beginning of the track. For this reason the CKF is modified to return all the states it found. For convenience of the user I added helper functions which allow to trim tracks. This is then exercised in the Examples track finding. blocked by - #3597 - #3644 - #3648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CKF tracks can have material states before any measurement was found. This is not true for outliers and holes. The logic is reworked so material, outliers and holes are handled in the same way if we have not found any measurements yet.
This is an attempt to also understand the output changes of #3391 better