Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use contains for maps and sets #3670

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

AJPfleger
Copy link
Contributor

I introduced also for Core/include/Acts/Geometry/GeometryHierarchyMap.hpp a contains method, as it would be expected from a map.

@AJPfleger AJPfleger added this to the next milestone Sep 30, 2024
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tried to check every occurrence for the logic to remain.

Copy link

📊: Physics performance monitoring for 98a1412

Full contents

physmon summary

Copy link

@kodiakhq kodiakhq bot merged commit f0dfbcd into acts-project:main Sep 30, 2024
45 checks passed
@AJPfleger AJPfleger deleted the contains branch September 30, 2024 22:46
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 1, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model Fails Athena tests This PR causes a failure in the Athena tests Seeding Track Finding Track Fitting Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants