Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(geo): Add portals + surfaces to closeGeometry and visitSurfaces #3678

Merged
merged 10 commits into from
Oct 4, 2024
Merged

refactor(geo): Add portals + surfaces to closeGeometry and visitSurfaces #3678

merged 10 commits into from
Oct 4, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Oct 2, 2024 •
edited
Loading

Also includes some cleanup.

Related to #3502

Blocked by:

@paulgessinger paulgessinger added this to the next milestone Oct 2, 2024
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Oct 2, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

📊: Physics performance monitoring for f5b7f06

Full contents

physmon summary

@paulgessinger paulgessinger mentioned this pull request Oct 2, 2024
Open
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Oct 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
23.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 238639b into acts-project:main Oct 4, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 4, 2024
@acts-project-service
Copy link
Collaborator

acts-project-service commented Oct 4, 2024 •
edited
Loading

🔴 Athena integration test results [238639b]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added Fails Athena tests This PR causes a failure in the Athena tests Breaks Athena build This PR breaks the Athena build labels Oct 4, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v37.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @asalzburger