Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update AthenaDumpReader, allow reading only SPs #3709

Conversation

benjaminhuth
Copy link
Member

Contains major refactoring of the Reader with the possibility to only read spacepoints if desired.

@benjaminhuth benjaminhuth added this to the next milestone Oct 10, 2024
@benjaminhuth benjaminhuth requested a review from noemina October 10, 2024 08:45
@github-actions github-actions bot added Component - Examples Affects the Examples module Event Data Model labels Oct 10, 2024
noemina
noemina previously approved these changes Oct 10, 2024
Copy link
Contributor

@noemina noemina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is code used to read ntuples produced in a specific ATLAS workflow.
It looks good to me, no major comments.

Copy link

github-actions bot commented Oct 10, 2024

📊: Physics performance monitoring for 44134e6

Full contents

physmon summary

@paulgessinger paulgessinger changed the title feat: Upate AthenaDumpReader, allow reading only SPs feat: Update AthenaDumpReader, allow reading only SPs Oct 10, 2024
Copy link

@kodiakhq kodiakhq bot merged commit c175666 into acts-project:main Oct 10, 2024
41 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 11, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
)

Contains major refactoring of the Reader with the possibility to only read spacepoints if desired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Event Data Model Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants