Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt scripts to GeoModel updates #3711

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: adapt scripts to GeoModel updates #3711

merged 3 commits into from
Oct 10, 2024

Conversation

asalzburger
Copy link
Contributor

This PR adapts the scripts for material mapping to the recent changes in GeoModel (-> ObjectFactory)

@asalzburger asalzburger added this to the next milestone Oct 10, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

📊: Physics performance monitoring for 69c070a

Full contents

physmon summary

dimitra97
dimitra97 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 2045800 into acts-project:main Oct 10, 2024
42 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [2045800]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 10, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@asalzburger @Rosie-Hasan
fix: adapt scripts to GeoModel updates (acts-project#3711)
34a3479 
This PR adapts the scripts for material mapping to the recent changes in GeoModel (-> `ObjectFactory`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitra97 dimitra97 dimitra97 approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module
Projects
None yet
Milestone
v37.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@asalzburger @acts-project-service @dimitra97 @paulgessinger