Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add comment on computation of impact parameter from the doublet #3728

Merged
merged 7 commits into from
Oct 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Core/include/Acts/Seeding/SeedFinder.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,15 @@ SeedFinder<external_spacepoint_t, grid_t, platform_t>::getCompatibleDoublets(
const float uT = xNewFrame * iDeltaR2;
const float vT = yNewFrame * iDeltaR2;

// interactionPointCut == true we apply this cut first cuts before
// coordinate transformation to avoid unnecessary calculations
// We check the interaction point by evaluating the minimal distance
// between the origin and the straight line connecting the two points in
// the doublets. Using a geometric similarity, the Im is given by
// yNewFrame * rM / deltaR <= m_config.impactMax
// However, we make here an approximation of the impact parameter
// which is valid under the assumption yNewFrame / xNewFrame is small
// The correct computation would be:
// yNewFrame * yNewFrame * rM * rM <= m_config.impactMax *
// m_config.impactMax * deltaR2
if (std::abs(rM * yNewFrame) <= impactMax * xNewFrame) {
// check if duplet cotTheta is within the region of interest
// cotTheta is defined as (deltaZ / deltaR) but instead we multiply
Expand Down
Loading