refactor: Rename TrackFinderPerformanceWriter in Examples
#3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples/Io/Performance/ActsExamples/Io/Performance/TrackFinderNTupleWriter.cpp
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Infrastructure
AJPfleger
reviewed
Oct 19, 2024
There was a problem hiding this comment.
I think git would be happier if we do first a PR with
- Rename TrackFinderPerformanceWriter to TrackFinderNTupleWriter
and then a second one with - Rename CKFPerformanceWriter to TrackFinderPerformanceWriter
Could you maybe split this up, that we have a better track which files moved?
andiwand
force-pushed
the
ex-rename-perf-writers
branch
from
c1598cc to
ba060ce
Compare
github-actions
bot
removed
Infrastructure
andiwand
changed the title
TrackFinderPerformanceWriter in Examples
|
AJPfleger
approved these changes
Oct 19, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 19, 2024
Followup of #3737 I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the `CKFPerformanceWriter` is generic enough to write the performance for any finder. Therefore I propose to - Rename `TrackFinderPerformanceWriter` to `TrackFinderNTupleWriter` (#3737) - Rename `CKFPerformanceWriter` to `TrackFinderPerformanceWriter` (this pr) blocked by - #3742 - #3737
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…cts-project#3745) Similar to acts-project#3737. I think performance writer should provide plots we can look at while the `VertexPerformanceWriter` is actually only writing NTuples.
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…ject#3737) I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the `CKFPerformanceWriter` is generic enough to write the performance for any finder. Therefore I propose to - Rename `TrackFinderPerformanceWriter` to `TrackFinderNTupleWriter` (this pr) - (and later) Rename `CKFPerformanceWriter` to `TrackFinderPerformanceWriter` blocked by - acts-project#3742
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
Followup of acts-project#3737 I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the `CKFPerformanceWriter` is generic enough to write the performance for any finder. Therefore I propose to - Rename `TrackFinderPerformanceWriter` to `TrackFinderNTupleWriter` (acts-project#3737) - Rename `CKFPerformanceWriter` to `TrackFinderPerformanceWriter` (this pr) blocked by - acts-project#3742 - acts-project#3737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the
CKFPerformanceWriteris generic enough to write the performance for any finder.Therefore I propose to
TrackFinderPerformanceWritertoTrackFinderNTupleWriter(this pr)CKFPerformanceWritertoTrackFinderPerformanceWriterblocked by