fix: FPE monitoring boost discovery, addr2line fallback #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
andiwand
approved these changes
Oct 17, 2024
|
acts-project-service
added
the
Fails Athena tests
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…#3747) This PR - Changes the way FPE monitoring configures `boost::stacktrace`: the fallback to `addr2line` is dropped as that doesn't work anyway - Change explicit `-Werror` in the CI to `CMAKE_COMPILE_WARNING_AS_ERROR=ON` - This is not applied in `try_compile`, which would otherwise cause false negatives because there are warnings we don't control. - Add a static method in `FpeMonitor` that returns if `backtrace` / symbolization support is on or not. - Make the sequencer fail early if it's configured to run the FPE monitor, has masks configured and symbolization is not supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
boost::stacktrace: the fallback toaddr2lineis dropped as that doesn't work anyway-Werrorin the CI toCMAKE_COMPILE_WARNING_AS_ERROR=ONtry_compile, which would otherwise cause false negatives because there are warnings we don't control.FpeMonitorthat returns ifbacktrace/ symbolization support is on or not.