Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tracking efficiency vs z0 #3764

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

ntadej
Copy link
Contributor

@ntadej ntadej commented Oct 21, 2024

This adds an additional tracking efficiency plot vs z0. It was useful for some studies that I was doing and it may be useful also for others.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

📊: Physics performance monitoring for 5571cb4

Full contents

physmon summary

@andiwand
Copy link
Contributor

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Oct 21, 2024
@paulgessinger
Copy link
Member

Could we wait with this for #3520 to be in? That also touches references and has been open for a while now.

@ntadej
Copy link
Contributor Author

ntadej commented Oct 21, 2024

I'm not in a rush. I just updated the references to confirm they are reproducible. Happy to update them again later.

@andiwand
Copy link
Contributor

#3520 is in now. If you can update the refs again we can get this in @ntadej

@github-actions github-actions bot removed Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Oct 22, 2024
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Oct 22, 2024
@ntadej
Copy link
Contributor Author

ntadej commented Oct 22, 2024

Note that I updated all references produced in the physmon tarball that are related to performance plots, even those that are not compared at the moment (I think it's 3 of them). I hope that's fine.

@andiwand andiwand added this to the next milestone Oct 22, 2024
Copy link

sonarcloud bot commented Oct 22, 2024

@kodiakhq kodiakhq bot merged commit 2e9eefc into acts-project:main Oct 22, 2024
42 checks passed
@paulgessinger paulgessinger modified the milestones: next, v37.2.0 Oct 24, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
This adds an additional tracking efficiency plot vs `z0`. It was useful for some studies that I was doing and it may be useful also for others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants