-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix enum conversion error in Podio plugin #4041
fix: Fix enum conversion error in Podio plugin #4041
Conversation
WalkthroughModify the Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This commit fixes a comparison to an enum without the use of the `toUnderlying` function. Also adapts the requirement to use the new Eigen concepts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Plugins/Podio/include/Acts/Plugins/Podio/PodioTrackStateContainer.hpp (1)
622-626
: A suggestion for readability, I have.More readable, the code would be, if requirements were split into separate lines, hmm?
requires( + // Check for fixed size Eigen base Concepts::eigen_base_is_fixed_size<val_t> && + // Verify row size against bound size Eigen::PlainObjectBase<val_t>::RowsAtCompileTime <= toUnderlying(eBoundSize) && + // Ensure matching dimensions Concepts::eigen_bases_have_same_num_rows<val_t, cov_t> && + // Verify square matrix requirement Concepts::eigen_base_is_square<cov_t>)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Plugins/Podio/include/Acts/Plugins/Podio/PodioTrackStateContainer.hpp
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (18)
- GitHub Check: CI Bridge / lcg_106a: [alma9, clang16]
- GitHub Check: CI Bridge / lcg_106a: [alma9, gcc14]
- GitHub Check: merge-sentinel
- GitHub Check: CI Bridge / lcg_106a: [alma9, gcc13]
- GitHub Check: CI Bridge / lcg_105: [alma9, clang16]
- GitHub Check: CI Bridge / lcg_105: [alma9, gcc13]
- GitHub Check: CI Bridge / linux_ubuntu_2204_clang
- GitHub Check: CI Bridge / linux_ubuntu_2204
- GitHub Check: CI Bridge / build_linux_ubuntu
- GitHub Check: CI Bridge / build_exatrkx
- GitHub Check: CI Bridge / build_exatrkx_cpu
- GitHub Check: CI Bridge / clang_tidy
- GitHub Check: missing_includes
- GitHub Check: macos
- GitHub Check: linux_ubuntu_extra (ubuntu2204_clang, 20)
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20)
- GitHub Check: build_debug
- GitHub Check: linux_ubuntu
🔇 Additional comments (1)
Plugins/Podio/include/Acts/Plugins/Podio/PodioTrackStateContainer.hpp (1)
622-626
: Approve the use of concepts, I do! Clearer constraints, they provide.Improved type safety and clearer error messages, the new concept-based constraints bring. Well-structured requirements for template parameters, they enforce.
|
This commit fixes a comparison to an enum without the use of the
toUnderlying
function. Also adapts the requirement to use the new Eigen concepts.Summary by CodeRabbit
allocateCalibrated_impl
method using modern C++ concepts