refactor: Delete non-compile tests

[paulgessinger]

This seemed like a good idea at the time, but the complexity seems not to be worth it.

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

• Use a conventional commits prefix: quick summary
  • We mostly use feat, fix, refactor, docs, chore and build types.
• A milestone will be assigned by one of the maintainers

Summary by CodeRabbit

• Tests

  • Removed legacy tests that verified compile-time constraints and specific immutability checks.
  • Added new unit tests for various components related to track parameters and measurement helpers.

• Chores

  • Streamlined the build process by eliminating outdated test-handling logic.

These updates enhance test coverage and clean up internal testing infrastructure without impacting end-user functionality.

[coderabbitai]

Walkthrough

Removed, much of the non-compilation test infrastructure has been. Deleted are helper macros in a dedicated header and the function that added non-compilation tests in CMake. Additionally, a suite of unit tests checking const correctness for TrackContainer no longer exists. Simplified, the test framework now is.

Changes

File(s)	Change Summary
Tests/CommonHelpers/.../NonCompileTestHelpers.hpp, Tests/UnitTests/CMakeLists.txt	Removed macros for non-compiling test suites and the function add_non_compile_test.
Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp	Removed unit tests ensuring TrackContainer compliance and const correctness.
Tests/UnitTests/Core/EventData/CMakeLists.txt	Added multiple unit tests for various components, removed non-compile test for MultiTrajectory.

Possibly related PRs

• test: Bounds regression tests #4001: Related changes in the removal of macros for non-compiling tests, indicating a direct connection in handling non-compiling tests.
• fix: oneAPI 2025 Fixes, main branch (2024.12.04.) #3938: Related to the removal of the non-compile test for MultiTrajectory, addressing the handling of non-compiling test cases.

Suggested labels

automerge, Track Fitting

Suggested reviewers

• andiwand

Poem

In code’s vast galaxy, change we bring,
Test macros vanish, like shadows they wing.
Removed our non-compiling paths, we have,
Simplified our build, peace does it salve.
May the force of clean code guide each line, always.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 475213c and 3a53593.

📒 Files selected for processing (4)

• Tests/CommonHelpers/Acts/Tests/CommonHelpers/NonCompileTestHelpers.hpp (0 hunks)
• Tests/UnitTests/CMakeLists.txt (0 hunks)
• Tests/UnitTests/Core/EventData/CMakeLists.txt (0 hunks)
• Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp (0 hunks)

💤 Files with no reviewable changes (4)

• Tests/UnitTests/CMakeLists.txt
• Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp
• Tests/CommonHelpers/Acts/Tests/CommonHelpers/NonCompileTestHelpers.hpp
• Tests/UnitTests/Core/EventData/CMakeLists.txt

⏰ Context from checks skipped due to timeout of 90000ms (15)

• GitHub Check: unused_files
• GitHub Check: missing_includes
• GitHub Check: CI Bridge / lcg_105: [alma9, gcc13]
• GitHub Check: CI Bridge / build_gnn_tensorrt
• GitHub Check: CI Bridge / linux_ubuntu_2204_clang
• GitHub Check: CI Bridge / linux_ubuntu_2204
• GitHub Check: CI Bridge / build_linux_ubuntu
• GitHub Check: CI Bridge / build_exatrkx_cpu
• GitHub Check: CI Bridge / build_exatrkx
• GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, clang++)
• GitHub Check: CI Bridge / clang_tidy
• GitHub Check: macos
• GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, g++)
• GitHub Check: linux_ubuntu
• GitHub Check: build_debug

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[asalzburger]

Good from my side.

[github-actions]

📊: Physics performance monitoring for 3a53593

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud