Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove more state data from the steppers and streamline the parameter resetter #879

Merged

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Nov 7, 2024

  • Shift the update of the step size in the stepper, so that we go from a "previous step size" to a "next step size".
  • Remove the volume material pointer from the state and instead get it from the navigator hand it through to the functions that need it
  • Remove the "path from surface" and reimplement it in the actors that use it
  • Remove the next_surface_aborter, which is superseded by the ckf_aborter in traccc (need to move the test to traccc)
  • Remove the previous surface index and instead use the surface link on the bound track parameters before they are updated
  • Remove the stepping direction and calculate it on the fly

Also streamlines the parameter resetter, as the jacobians are already default initialized correctly and a separate kernel is not needed, since the relevant functionality already exists on the tracking_surface

@niermann999

This comment was marked as outdated.

@niermann999 niermann999 added refactor refactoring the current codes priority: medium medium priority blocked This item is blocked by another item labels Nov 7, 2024
@niermann999 niermann999 force-pushed the ref-decouple-stepper-actors branch from a320992 to 7147eb8 Compare November 11, 2024 12:43
@niermann999 niermann999 marked this pull request as ready for review November 11, 2024 12:43
@niermann999 niermann999 force-pushed the ref-decouple-stepper-actors branch 2 times, most recently from bd2e66e to a6c9291 Compare November 11, 2024 14:25
@niermann999 niermann999 removed the blocked This item is blocked by another item label Nov 11, 2024
@niermann999 niermann999 force-pushed the ref-decouple-stepper-actors branch 3 times, most recently from 2604662 to 1fd1d54 Compare November 13, 2024 17:09
Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@niermann999 niermann999 force-pushed the ref-decouple-stepper-actors branch from 1fd1d54 to 2bb45e9 Compare November 15, 2024 14:20
Copy link

@niermann999 niermann999 merged commit 9c0f9af into acts-project:main Nov 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium medium priority refactor refactoring the current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants