Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fabs instead of abs in set_phi to be nice with sycl/clang20 #889

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

flg
Copy link
Contributor

@flg flg commented Nov 26, 2024

This correction was suggested by @niermann999 as a fix for a compile error with a recent SYCL compiler. And worked. This is mostly to remind detray and ACTS experts that this is something to look into. Maybe this needs to be applied elsewhere.

For info the compiler is:

$ clang++ -v
clang version 20.0.0git (https://github.com/intel/llvm e95b34bb2bcef2641d88ca2e09d628039ef269d7)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /opt/intel/oneapi/compiler/2025.0/bin
Build config: +assertions
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/13
Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/13
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Candidate multilib: x32;@mx32
Selected multilib: .;@m64
Found HIP installation: /opt/rocm, version 6.2.41134

from 24/11/2024 daily release of Intel's LLVM:
https://github.com/intel/llvm/releases/download/nightly-2024-11-24/sycl_linux.tar.gz

Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@niermann999 niermann999 merged commit 99e0a45 into acts-project:main Nov 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants