Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double precision build in CI #404

Closed
beomki-yeo opened this issue May 18, 2023 · 3 comments · Fixed by #669
Closed

Add double precision build in CI #404

beomki-yeo opened this issue May 18, 2023 · 3 comments · Fixed by #669
Labels
cicd Changes related to the CI system good first issue Good for newcomers

Comments

@beomki-yeo
Copy link
Contributor

It seems traccc CI is not running with TRACCC_CUSTOM_SCALARTYPE=double && DETRAY_CUSTOM_SCALARTYPE=double option. Is it intended or can we simply add it?

@guilhermeAlmeida1 guilhermeAlmeida1 added the cicd Changes related to the CI system label May 19, 2023
@stephenswat
Copy link
Member

Hi Beomki, we can add a double-precision build quite easily. However, I think it would be wise to keep the number of builds in check; our CI already consumes about 3 runner-hours for every build, so simply doubling the number of builds would be a lot of added work. We can think about adding double-precision builds more specifically (i.e. only for one specific CUDA job). I would also like to reduce the number of jobs in general, and reduce the cost of compilation by pre-compiling some dependencies into a custom image, but those are things we can look at later.

@guilhermeAlmeida1
Copy link
Collaborator

guilhermeAlmeida1 commented May 25, 2023

I don't think we have much to gain from additional double-precision builds, at least for the moment.

@beomki-yeo
Copy link
Contributor Author

I still worry that the project is not compiled with double precision or having weird physics results unless it is not included in the CI.
We don't have to add double precision for every CI build. one from CPU and one from CUDA build will be enough.

@stephenswat stephenswat added the good first issue Good for newcomers label May 28, 2023
@beomki-yeo beomki-yeo linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Changes related to the CI system good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants