Fix compilation issue in double precision #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Since the problem is with using double for the scalar type, we should not add a cast to float, but one rather to double. 😉
And we should add some CI tests for double precision. 🤔 I'll try to find time tomorrow to look into that, if somebody doesn't beat me to it. 😉
|
I am happy with having a double precision in CI. |
beomki-yeo
force-pushed
the
fix-double-compilation-issue
branch
from
691a439 to
3175f19
Compare
beomki-yeo
force-pushed
the
fix-double-compilation-issue
branch
from
3175f19 to
991f5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently double precision is not compiled