-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finding performance writer: comments + fake tracks #575
Finding performance writer: comments + fake tracks #575
Conversation
If I’m not mistaken, we can do the following math.
|
Great I assigned myself for review |
Thanks a lot Beom Ki! :) But let's wait the performance measurement code reorganization by Attila, as he mentioned on PR 578 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I might need to understand the logic clearly. Actually I don't know the exact definition of fake rate. Could you find its definition?
74e5f21
to
27753e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will update the branch and merge
Okay, thanks! |
While writing a ROOT documentation for the
finding
andambiguity resolution
algorithms, I thought it would be interesting to have a visualization for thefake tracks
rates. Thegreedy ambiguity resolution algorithm
successfully managed to remove every track duplicates while retaining reasonable efficiency, but I wanted to make sure that it would also greatly reduce the number of fake tracks, at least on the data generated by the toy detector (mostly 100GeV muons).The
fake_tracks_plot_tool.hpp
file is a duplication of the code from theduplication_plot_tool.hpp
file. I think it would be better to merge the two codes, so I will do it if you think it’s a good idea.If you like the idea, I will write the corresponding documentation and append it to the
doc/root/README.md
file from PR 535For example, with toy detector generated data and 100GeV muons, the mean value for “fake tracks” goes from 1.707 with the
finding algorithm
down to 0.0155 after theambiguity resolution algorithm
(a x110 decrease!):After the
finding algorithm
:After the
ambiguity resolution algorithm
:I used the following code to generate the ROOT data with
traccc_seeding_example
: