Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpaka: Build correct workDiv for HIP devices. #580

Merged
merged 1 commit into from
May 20, 2024

Conversation

CrossR
Copy link
Contributor

@CrossR CrossR commented May 8, 2024

This is a tiny change that was missed as part of the Alpaka HIP work.

Without it, we'd be making workDivs for the CPU and attempting to run them on the GPU...which isn't ideal and obviously broke lots of things (in testing the HIP code would run part of the seeding before crashing, due to incorrectly formed spacepoint binning).

With this change, we now have HIP-backed Alpaka results working!
This is on a machine with a few AMD Instinct MI210, and 2 AMD EPYC 7F72 CPUs.

==> Statistics ... 
- read    10472 spacepoints from 1598 modules
- created  (cpu)  12264 seeds
- created (alpaka)  12264 seeds
==>Elapsed times...
            Hit reading  (cpu)  245 ms
              Seeding (alpaka)  29 ms
                Seeding  (cpu)  252 ms
         Track params (alpaka)  2 ms
           Track params  (cpu)  3 ms
                     Wall time  754 ms

This is just from the seeding_example at the moment, but will look at integrating with my other PR (#558) to get some more realistic numbers soon.

There is still an instability, where if compiled for debugging there is a crash...which I'm hoping is the same sort of crash that I'm hitting every so often in the Alpaka-CUDA version, so will be debugging separately.

@CrossR CrossR force-pushed the CrossR/HIPWorkDiv branch 2 times, most recently from d224329 to 738c839 Compare May 8, 2024 15:14
@StewMH
Copy link
Contributor

StewMH commented May 20, 2024

@krasznaa @beomki-yeo could we have a review of this please? It's a small change.

Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@krasznaa krasznaa force-pushed the CrossR/HIPWorkDiv branch from 738c839 to a251447 Compare May 20, 2024 14:41
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, we should've pushed it in a while ago... 😦

@krasznaa krasznaa enabled auto-merge May 20, 2024 14:42
@krasznaa krasznaa merged commit da1f6e3 into acts-project:main May 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants