Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Ignore Update, main branch (2024.05.11.) #583

Merged
merged 1 commit into from
May 16, 2024

Conversation

krasznaa
Copy link
Member

This has been bugging me since a while, so finally it's time to fix it.

Many of our unit tests are creating files/directories under data/. While that is a separate issue of its own, this just always leaves me with a bunch of directories in my local clone that git doesn't know about. Worse yet, VSCode really freaks out about the thousands of files that it all of a sudden tries to track.

The */ formalism seems to do what we need there. 🤔

@krasznaa krasznaa added the improvement Improve an existing feature label May 11, 2024
@krasznaa krasznaa force-pushed the DataIgnore-main-20240511 branch from a1cfbb0 to 5adcf2f Compare May 15, 2024 15:04
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@krasznaa krasznaa merged commit 6de58c7 into acts-project:main May 16, 2024
17 of 18 checks passed
@krasznaa krasznaa deleted the DataIgnore-main-20240511 branch May 16, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants