Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update to detray version 0.65.0 #586

Merged
merged 1 commit into from
May 13, 2024

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented May 13, 2024

Mainly removes a few instances of too strict checking for the material and the stepper, as well as removing the transform for concentric cylinders and setting their boundary values correctly.

The material maps should now run by just adding the material map file to the detector reader

@krasznaa
Copy link
Member

At least a sentence of a description for the update could be good. 😛

@niermann999
Copy link
Contributor Author

At least a sentence of a description for the update could be good. 😛

Yes, sorry, I had an appointment and just about managed to get the CI running before I had to leave :) I am not too optimistic about this fixing the bug that came up in the ttbar sample though, but let's see

@krasznaa krasznaa merged commit a2f2d23 into acts-project:main May 13, 2024
17 of 18 checks passed
@krasznaa
Copy link
Member

It was absolutely worth a shot. But unfortunately the crash, while it changed a little, is still there. 😦

@niermann999
Copy link
Contributor Author

It was absolutely worth a shot. But unfortunately the crash, while it changed a little, is still there. 😦

OK, I discovered a problem in a detray sample as well and I am trying to recreate that atm. Otherwise, can you give me a recipe on how to run the problematic event?

@krasznaa
Copy link
Member

krasznaa commented May 13, 2024

It was absolutely worth a shot. But unfortunately the crash, while it changed a little, is still there. 😦

OK, I discovered a problem in a detray sample as well and I am trying to recreate that atm. Otherwise, can you give me a recipe on how to run the problematic event?

If you build the current main branch of traccc, you can reproduce the crash with:

./bin/traccc_seq_example --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --use-detray-detector --digitization-file=geometries/odd/odd-digi-geometric-config.json --input-directory=/afs/cern.ch/user/k/krasznaa/work/public/traccc-odd-crash --input-events=1 --input-skip 295

As long as you have access to AFS that is. (On pcadp04 you do.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants