Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to detray v0.65.1 #589

Merged
merged 1 commit into from
May 14, 2024

Conversation

niermann999
Copy link
Contributor

Fixing a navigation bug in detray that should make the navigator abort a track correctly that runs out of candidates

@niermann999
Copy link
Contributor Author

I tested this on the event in /afs/cern.ch/user/k/krasznaa/work/public/traccc-odd-crash and it seems to run without crashes now, even if the overstepping tolerance is too low:
No material, overstep tolerance -100um:

==> Statistics ... 
- read     206720 cells from 14548 modules
- created  56092 measurements. 
- created  56092 space points. 
- created  7502 seeds
- found    9274 tracks
- fitted   9274 tracks
- resolved 2049 tracks
==> Elapsed times...
                    Read cells  240 ms
                Clusterization  8 ms
          Spacepoint formation  0 ms
                       Seeding  87 ms
       Track params estimation  1 ms
                 Track finding  708 ms
                 Track fitting  259 ms
    Track ambiguity resolution  849 ms
                     Wall time  2155 ms

No material, overstep tolerance -300um:

==> Statistics ... 
- read     206720 cells from 14548 modules
- created  56092 measurements. 
- created  56092 space points. 
- created  7502 seeds
- found    9302 tracks
- fitted   9302 tracks
- resolved 2055 tracks
==> Elapsed times...
                    Read cells  240 ms
                Clusterization  8 ms
          Spacepoint formation  0 ms
                       Seeding  87 ms
       Track params estimation  1 ms
                 Track finding  712 ms
                 Track fitting  260 ms
    Track ambiguity resolution  867 ms
                     Wall time  2179 ms

With material, overstep tolernace -300um:

==> Statistics ... 
- read     206720 cells from 14548 modules
- created  56092 measurements. 
- created  56092 space points. 
- created  7502 seeds
- found    17850 tracks
- fitted   17850 tracks
- resolved 2110 tracks
==> Elapsed times...
                    Read cells  239 ms
                Clusterization  8 ms
          Spacepoint formation  0 ms
                       Seeding  87 ms
       Track params estimation  1 ms
                 Track finding  1023 ms
                 Track fitting  784 ms
    Track ambiguity resolution  3766 ms
                     Wall time  5912 ms

@niermann999 niermann999 changed the title fix: Update to detray v0.65. fix: Update to detray v0.65.1 May 14, 2024
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the CI is happy, let's absolutely go for it.

@niermann999
Copy link
Contributor Author

In case the overstepping tolerance cannot be raised further, we will need the volume grid in the navigation, which is not yet implemented in detray. So, it is possible that some tracks are still failing here and will not be reconstructed properly, but at least it does not crash anymore

@niermann999 niermann999 merged commit a337215 into acts-project:main May 14, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants