Truth Particle Update, main branch (2024.05.23.) #592
Merged
+357
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
added
tests
krasznaa
force-pushed
the
TruthParticleUpdate-main-20240523
branch
from
4639bd8 to
c1059ab
Compare
|
Anybody willing to give this one a look? I'd really like to progress on this front... 🤔 |
stephenswat
requested changes
May 29, 2024
stephenswat
approved these changes
May 29, 2024
At the same time made the member names of traccc::particle a little more to my liking.
So that it would be easier to introduce an overload that will handle traccc::particle_container_types::host.
Including the "truth measurements" being assigned to the particle properties. Updated the measurement reading code to allow for the same Acts -> Detray geometry ID re-mapping that we are doing for the cells as well. Added a naive tests for checking if the code works at all.
krasznaa
force-pushed
the
TruthParticleUpdate-main-20240523
branch
from
c1059ab to
ea86f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first piece of #582.
It introduces
traccc::particle_container_types, which I in turn want to use for efficiency measurements. The rename on the members oftraccc::particleis not mandatory. I just didn't like theposname at all, and since most other variables have "full length" names, I thought thatmomwould be better asmomentum. But if you have a strong different opinion, I'm open for a discussion. 🤔Since I tested it with #582 already, I think the I/O code is okay. Though the unit test added in this PR is indeed pretty weak. 😦