Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truth Particle Update, main branch (2024.05.23.) #592

Merged

Conversation

krasznaa
Copy link
Member

This is the first piece of #582.

It introduces traccc::particle_container_types, which I in turn want to use for efficiency measurements. The rename on the members of traccc::particle is not mandatory. I just didn't like the pos name at all, and since most other variables have "full length" names, I thought that mom would be better as momentum. But if you have a strong different opinion, I'm open for a discussion. 🤔

Since I tested it with #582 already, I think the I/O code is okay. Though the unit test added in this PR is indeed pretty weak. 😦

@krasznaa krasznaa added tests Make sure the code keeps working edm Changes to the data model labels May 23, 2024
@krasznaa krasznaa force-pushed the TruthParticleUpdate-main-20240523 branch from 4639bd8 to c1059ab Compare May 23, 2024 19:19
@krasznaa
Copy link
Member Author

Anybody willing to give this one a look? I'd really like to progress on this front... 🤔

@stephenswat, @beomki-yeo?

krasznaa added 3 commits May 29, 2024 17:17
At the same time made the member names of traccc::particle a little
more to my liking.
So that it would be easier to introduce an overload that will
handle traccc::particle_container_types::host.
Including the "truth measurements" being assigned to the particle
properties.

Updated the measurement reading code to allow for the same
Acts -> Detray geometry ID re-mapping that we are doing for the
cells as well.

Added a naive tests for checking if the code works at all.
@krasznaa krasznaa force-pushed the TruthParticleUpdate-main-20240523 branch from c1059ab to ea86f9b Compare May 29, 2024 15:17
@krasznaa krasznaa merged commit df0547d into acts-project:main May 29, 2024
18 of 20 checks passed
@krasznaa krasznaa deleted the TruthParticleUpdate-main-20240523 branch May 29, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edm Changes to the data model tests Make sure the code keeps working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants