Add helper class for thread and block identifiers #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
refactor
|
I haven't tested this on SYCL yet, I just guessed at the function names and crossed my fingers. |
krasznaa
requested changes
May 29, 2024
device/common/include/traccc/clusterization/device/ccl_kernel.hpp
Outdated
Show resolved
Hide resolved
stephenswat
force-pushed
the
feat/thread_id
branch
2 times, most recently
from
912cda0 to
d63e4c6
Compare
stephenswat
force-pushed
the
feat/thread_id
branch
from
d63e4c6 to
9dc060a
Compare
|
I've split this into a CUDA and a SYCL class now, unified by - you guessed it - a concept. |
stephenswat
force-pushed
the
feat/thread_id
branch
from
9dc060a to
fe302a2
Compare
stephenswat
force-pushed
the
feat/thread_id
branch
from
fe302a2 to
01ecf6f
Compare
stephenswat
force-pushed
the
feat/thread_id
branch
from
01ecf6f to
66355dd
Compare
|
@CrossR could you check if the Alpaka code in this PR makes sense? |
|
Looks good! |
krasznaa
approved these changes
Jul 31, 2024
stephenswat
force-pushed
the
feat/thread_id
branch
5 times, most recently
from
a0f6c04 to
69c0adc
Compare
The number of parameters in a lot of our kernels and device functions is becoming absurdly large. Part of this is that we are passing variables like thread identifiers, block identifiers and block sizes for each of these functions. Not only does this make code harder to read, it may also increase register pressure on the device causing potentially slow spilling. This commit introduces a new type that handles thread identifiers more compactly and efficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of parameters in a lot of our kernels and device functions is becoming absurdly large. Part of this is that we are passing variables like thread identifiers, block identifiers and block sizes for each of these functions. Not only does this make code harder to read, it may also increase register pressure on the device causing potentially slow spilling. This commit introduces a new type that handles thread identifiers more compactly and efficiently.