Remove naming conflicts with module keyword
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C++20, `module` becomes a keyword. For obvious reasons, we use this as a variable name all over our code, but some compilers are not fans of this naming collision: they will emit warning or even errors because using keywords as variable names is poor practice. This commit replaces occurances of `module` with `mod` to clear up the ambiguity.
stephenswat
force-pushed
the
fix/module_keyword
branch
from
6ecdc61 to
46ee821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++20,
modulebecomes a keyword. For obvious reasons, we use this as a variable name all over our code, but some compilers are not fans of this naming collision: they will emit warning or even errors because using keywords as variable names is poor practice. This commit replaces occurances ofmodulewithmodto clear up the ambiguity.