Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove naming conflicts with module keyword #600

Merged
merged 2 commits into from
May 31, 2024

Conversation

stephenswat
Copy link
Member

In C++20, module becomes a keyword. For obvious reasons, we use this as a variable name all over our code, but some compilers are not fans of this naming collision: they will emit warning or even errors because using keywords as variable names is poor practice. This commit replaces occurances of module with mod to clear up the ambiguity.

@stephenswat stephenswat added the bug Something isn't working label May 31, 2024
In C++20, `module` becomes a keyword. For obvious reasons, we use this
as a variable name all over our code, but some compilers are not fans of
this naming collision: they will emit warning or even errors because
using keywords as variable names is poor practice. This commit replaces
occurances of `module` with `mod` to clear up the ambiguity.
@stephenswat stephenswat force-pushed the fix/module_keyword branch from 6ecdc61 to 46ee821 Compare May 31, 2024 10:17
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stephenswat stephenswat enabled auto-merge May 31, 2024 11:42
@stephenswat stephenswat merged commit 8555751 into acts-project:main May 31, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants