Add blockwise add and count in CUDA and SYCL #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
feature
stephenswat
assigned krasznaa, niermann999 and beomki-yeo and unassigned krasznaa, niermann999 and beomki-yeo
krasznaa
approved these changes
Jun 13, 2024
krasznaa
requested changes
Jun 13, 2024
tests/cuda/test_barrier.cu
Outdated
|
|
||
| testBarrierCount<<<1, 1024>>>(out); | ||
|
|
||
| ASSERT_EQ(cudaPeekAtLastError(), cudaSuccess); |
There was a problem hiding this comment.
On a synchronous kernel execution you might as well do:
Suggested change
| ASSERT_EQ(cudaPeekAtLastError(), cudaSuccess); | |
| ASSERT_EQ(cudaDeviceSynchronize(), cudaSuccess); |
Maybe in addition to your call. Though for "synchronous kernels" I've rather been using cudaGetLastError() instead. 🤔 For instance:
|
Oh sorry I only pushed these so I could run them through act on pcadp04, I'll turn this into a draft and finalize.
|
This commit extends our barrier types with the `blockAnd` and `blockCount` methods, the latter of which is a ballot vote across a work group. Implemented in both CUDA and SYCL.
This commit adds tests for the AND, OR, and COUNT methods on the barrier types for the CUDA and SYCL platforms.
stephenswat
force-pushed
the
feat/barrier_and_count
branch
from
fcbeff9 to
fbe62d8
Compare
|
Okay, this is ready to go now. 👍 |
krasznaa
approved these changes
Jun 18, 2024
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 18, 2024
This fixes an embarassing bug in acts-project#610 where I had apparently mass-changed `barrierCount` into `barrierOr`. Oops!
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 18, 2024
This fixes an embarassing bug in acts-project#610 where I had apparently mass-changed `barrierCount` into `barrierOr`. Oops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends our barrier types with the
blockAndandblockCountmethods, the latter of which is a ballot vote across a work group. Implemented in both CUDA and SYCL.