Fix broken CUDA unit test after #605 #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected values in this unit tests were consistenly a value of 0.5 off since the merging of acts-project#605. This commit updates the expected values, and also renames the unit test to be more in line with our other tests.
stephenswat
added
bug
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 18, 2024
This is the SYCL equivalent of acts-project#614.
This was referenced Jun 18, 2024
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 19, 2024
This is the SYCL equivalent of acts-project#614.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected values in this unit tests were consistenly a value of 0.5 off since the merging of #605. This commit updates the expected values, and also renames the unit test to be more in line with our other tests.