Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CUDA unit test after #605 #614

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

stephenswat
Copy link
Member

The expected values in this unit tests were consistenly a value of 0.5 off since the merging of #605. This commit updates the expected values, and also renames the unit test to be more in line with our other tests.

The expected values in this unit tests were consistenly a value of 0.5
off since the merging of acts-project#605. This commit updates the expected values,
and also renames the unit test to be more in line with our other tests.
@stephenswat stephenswat added bug Something isn't working tests Make sure the code keeps working cuda Changes related to CUDA labels Jun 14, 2024
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stephenswat stephenswat merged commit 5e8af79 into acts-project:main Jun 15, 2024
20 of 21 checks passed
stephenswat added a commit to stephenswat/traccc that referenced this pull request Jun 18, 2024
stephenswat added a commit to stephenswat/traccc that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda Changes related to CUDA tests Make sure the code keeps working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants