Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update extern tags #628

Merged
merged 17 commits into from
Aug 1, 2024
Merged

build: update extern tags #628

merged 17 commits into from
Aug 1, 2024

Conversation

fredevb
Copy link
Contributor

@fredevb fredevb commented Jun 21, 2024 •
edited
Loading

  • Fixed some implicit conversion warnings when enabling -Wfloat-conversion.
  • Updated detray tag to v0.72.1
  • Updated covfie tag to v0.10.0

These changes are needed for the traccc plugin to pass the ACTS CI.

@fredevb fredevb changed the title uild: include tbb as a system library, add compile flag -Wfloat-conversion, and removed implicit conversion warnings. build: tbb as a system library, -Wfloat-conversion, and implicit conversion warnings. Jun 21, 2024
@fredevb fredevb marked this pull request as draft June 21, 2024 16:48
@stephenswat
Copy link
Member

If it helps, there are tools that you can use to run GitHub Actions-like CI jobs on your local machine so you don't need to constantly wait for the CI to finish. Check out https://github.com/nektos/act.

@stephenswat stephenswat added build This relates to the build system bug Something isn't working labels Jun 22, 2024
@stephenswat stephenswat changed the title build: tbb as a system library, -Wfloat-conversion, and implicit conversion warnings. build: tbb as a system library, -Wfloat-conversion, and implicit conversion warnings Jul 10, 2024
@fredevb fredevb changed the title build: tbb as a system library, -Wfloat-conversion, and implicit conversion warnings build: update detray tag, add -Wfloat-conversion, and fix implicit conversion warnings Jul 11, 2024
@fredevb fredevb marked this pull request as ready for review July 11, 2024 08:19
@stephenswat
Copy link
Member

Hi @fredevb, what's the status on this; do you need any help getting this sorted out?

@fredevb fredevb changed the title build: update detray tag, add -Wfloat-conversion, and fix implicit conversion warnings build: update detray and covfie tag, add -Wfloat-conversion, and fix implicit conversion warnings Jul 22, 2024
@fredevb fredevb changed the title build: update detray and covfie tag, add -Wfloat-conversion, and fix implicit conversion warnings build: update detray + covfie + acts tag, add -Wfloat-conversion, and fix implicit conversion warnings Jul 23, 2024
@fredevb fredevb changed the title build: update detray + covfie + acts tag, add -Wfloat-conversion, and fix implicit conversion warnings build: update detray + covfie + acts tags, add -Wfloat-conversion, and fix implicit conversion warnings Jul 23, 2024
@fredevb fredevb changed the title build: update detray + covfie + acts tags, add -Wfloat-conversion, and fix implicit conversion warnings build: update detray + covfie + acts tags, update cxx standard to 20, add -Wfloat-conversion, and fix implicit conversion warnings Jul 23, 2024
@fredevb fredevb changed the title build: update detray + covfie + acts tags, update cxx standard to 20, add -Wfloat-conversion, and fix implicit conversion warnings build: update extern targs, cxx standard to 20, and compile flags Jul 23, 2024
@fredevb fredevb changed the title build: update extern targs, cxx standard to 20, and compile flags build: update extern tags, cxx standard to 20, and compile flags Jul 23, 2024
stephenswat added a commit to stephenswat/traccc that referenced this pull request Jul 26, 2024
@stephenswat
Temporarily disable SYCL Kalman fitter test
780be1f 
As shown in acts-project#655, this is creating a lot of headache. I am looking for a
fix but in the meanwhile this is holding up acts-project#628, so I want to
temporarily disable these tests.
stephenswat added a commit to stephenswat/traccc that referenced this pull request Jul 26, 2024
@stephenswat
Temporarily disable SYCL Kalman fitter test
36a622c 
As shown in acts-project#655, this is creating a lot of headache. I am looking for a
fix but in the meanwhile this is holding up acts-project#628, so I want to
temporarily disable these tests.
@stephenswat stephenswat mentioned this pull request Jul 26, 2024
Merged
stephenswat added a commit to stephenswat/traccc that referenced this pull request Jul 26, 2024
@stephenswat
Temporarily disable SYCL Kalman fitter test
716fb7d 
As shown in acts-project#655, this is creating a lot of headache. I am looking for a
fix but in the meanwhile this is holding up acts-project#628, so I want to
temporarily disable these tests.
@fredevb fredevb changed the title build: update extern tags, cxx standard to 20, and compile flags build: update extern tags, added explicit type conversion Jul 26, 2024
@fredevb fredevb changed the title build: update extern tags, added explicit type conversion build: update extern tags, added explicit conversion between types Jul 26, 2024
@fredevb fredevb changed the title build: update extern tags, added explicit conversion between types build: update extern tags, explicit conversion between types Jul 26, 2024
@stephenswat
Copy link
Member

Can you please rebase this on main, as the float conversion should be fixed in #658.

@fredevb fredevb changed the title build: update extern tags, explicit conversion between types build: update extern tags Jul 31, 2024
@stephenswat stephenswat merged commit 605538d into acts-project:main Aug 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenswat stephenswat stephenswat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working build This relates to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredevb @stephenswat