-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update extern tags #628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it helps, there are tools that you can use to run GitHub Actions-like CI jobs on your local machine so you don't need to constantly wait for the CI to finish. Check out https://github.com/nektos/act. |
Hi @fredevb, what's the status on this; do you need any help getting this sorted out? |
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jul 26, 2024
As shown in acts-project#655, this is creating a lot of headache. I am looking for a fix but in the meanwhile this is holding up acts-project#628, so I want to temporarily disable these tests.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jul 26, 2024
As shown in acts-project#655, this is creating a lot of headache. I am looking for a fix but in the meanwhile this is holding up acts-project#628, so I want to temporarily disable these tests.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jul 26, 2024
As shown in acts-project#655, this is creating a lot of headache. I am looking for a fix but in the meanwhile this is holding up acts-project#628, so I want to temporarily disable these tests.
stephenswat
reviewed
Jul 30, 2024
Can you please rebase this on main, as the float conversion should be fixed in #658. |
stephenswat
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed for the traccc plugin to pass the ACTS CI.