Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero output in mutex and unique lock tests #637

Merged

Conversation

stephenswat
Copy link
Member

Turns out that on the platforms we test for, memory allocations are zeroed out implicitly. If you try running the code on architectures that don't do this, though, the results are incorrect. To correct for this, this commit adds explicit zeroing for the output variables of the mutex and unique lock tests.

Turns out that on the platforms we test for, memory allocations are
zeroed out implicitly. If you try running the code on architectures that
don't do this, though, the results are incorrect. To correct for this,
this commit adds explicit zeroing for the output variables of the mutex
and unique lock tests.
@stephenswat stephenswat added bug Something isn't working tests Make sure the code keeps working cuda Changes related to CUDA sycl Changes related to SYCL labels Jul 3, 2024
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough

@stephenswat stephenswat enabled auto-merge July 3, 2024 08:42
@stephenswat stephenswat merged commit ac84f54 into acts-project:main Jul 3, 2024
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda Changes related to CUDA sycl Changes related to SYCL tests Make sure the code keeps working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants